Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GraphQL): Nested Auth Rules not working properly. (#7915) (#8084) #8571

Merged
merged 1 commit into from
Jan 6, 2023
Merged

fix(GraphQL): Nested Auth Rules not working properly. (#7915) (#8084) #8571

merged 1 commit into from
Jan 6, 2023

Conversation

all-seeing-code
Copy link
Contributor

@all-seeing-code all-seeing-code commented Jan 4, 2023 •
edited
Loading

Improves nested auth rule implementation in graphql.

(cherry picked from commit e7a1931)

Co-authored-by: minhaj-shakeel [email protected]
(cherry picked from commit 26845c4)

@NamanJain8 @all-seeing-code
fix(GraphQL): Nested Auth Rules not working properly. (#7915) (#8084)
c8b63eb 
(cherry picked from commit e7a1931)

Co-authored-by: minhaj-shakeel <[email protected]>
(cherry picked from commit 26845c4)
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Jan 4, 2023
@all-seeing-code all-seeing-code added the slash-to-main PRs which bring slash branch on par with main. label Jan 4, 2023
@coveralls
Copy link

Coverage Status

Coverage: 64.453% (+0.09%) from 64.366% when pulling c8b63eb on anurag/cp-gql-nested-auth into 8c72479 on main.

@mangalaman93
Copy link
Contributor

@anurags92 could you add more explanation to the commit for what is going on?

@amaster507
Copy link
Contributor

@mangalaman93 I have context on this, iirc, this was related to an issue I reported via DM on Discuss. Let me see if I can find you and add you to the conversation.

@amaster507
Copy link
Contributor

If I added both of your correct users @anurags92 and @mangalaman93 then you both should now have access to: https://discuss.dgraph.io/t/security-bug-auth-security-rule-not-honored-correctly/13372/11?u=amaster507

@mangalaman93
Copy link
Contributor

That helps, thank you so much.

@skrdgraph skrdgraph merged commit d09d679 into main Jan 6, 2023
@skrdgraph skrdgraph deleted the anurag/cp-gql-nested-auth branch January 6, 2023 22:03
@jdgamble555
Copy link

What is this exactly? That link is dead. is this related to https://discuss.dgraph.io/t/bug-auth-rules-of-parent-not-respected-when-child-with-hasinverse-is-added/12955

?

J

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmcneely matthewmcneely matthewmcneely approved these changes

@MichelDiz MichelDiz MichelDiz approved these changes

@skrdgraph skrdgraph skrdgraph approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

Assignees
No one assigned
Labels
area/graphql Issues related to GraphQL support on Dgraph. slash-to-main PRs which bring slash branch on par with main.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@all-seeing-code @CLAassistant @coveralls @mangalaman93 @amaster507 @jdgamble555 @matthewmcneely @MichelDiz @skrdgraph @NamanJain8